Support parsing php 8.3 typed class constants#406
Open
TysonAndre wants to merge 4 commits intomicrosoft:mainfrom
Open
Support parsing php 8.3 typed class constants#406TysonAndre wants to merge 4 commits intomicrosoft:mainfrom
TysonAndre wants to merge 4 commits intomicrosoft:mainfrom
Conversation
https://wiki.php.net/rfc/typed_class_constants#inheritance_and_variance As of php 8.3, class constants can have the same types as parameters (including union, intersection, and DNF types) Start testing with php 8.3
Contributor
Author
-<ST_IN_SCRIPTING>"yield"{WHITESPACE}"from"[^a-zA-Z0-9_\x80-\xff] {
+<ST_IN_SCRIPTING>"yield"{WHITESPACE_OR_COMMENTS}"from"[^a-zA-Z0-9_\x80-\xff] {
yyless(yyleng - 1);
HANDLE_NEWLINES(yytext, yyleng);
RETURN_TOKEN_WITH_IDENT(T_YIELD_FROM);tests/cases/lexical/keyword5.php.tokens started failing in php 8.3 because php now lexes |
Contributor
Author
|
The tests won't run until https://docs.github.com/en/actions/managing-workflow-runs/approving-workflow-runs-from-public-forks
|
Assume most class constants won't add a type and parse the name if ambiguous.
ghostwriter
approved these changes
Apr 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wiki.php.net/rfc/typed_class_constants#inheritance_and_variance As of php 8.3, class constants can have the same types as parameters (including union, intersection, and DNF types)
Start testing with php 8.3