PHP8.4: Support new without parenthesis#415
Open
dantleech wants to merge 1 commit intomicrosoft:mainfrom
Open
Conversation
dantleech
force-pushed
the
84-new-no-parens
branch
from
545b5ba to
5873b30
Compare
dantleech
commented
Jan 13, 2025
|
|
||
| // PHP8.4 new with no parenthesis | ||
| if ($this->getCurrentToken()->kind === TokenKind::ArrowToken) { | ||
| return $this->parsePostfixExpressionRest($objectCreationExpression); |
Contributor
Author
There was a problem hiding this comment.
In line with the rest of this libaray this should probably have a run time php_version() > 80400?
(incidentally would be good to refactor so that it didn't depend on the runtime PHP version)
Contributor
There was a problem hiding this comment.
+1 for being able to configure at what PHP level the parser works
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(from Phpactor's fork - not tested extensively)