MaxPageSize paging parameter consistent casing #9565
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
the
emitter:client:csharp
radhgupta
force-pushed
the
maxpagesizeCasing
branch
from
85136e1 to
2c458ff
Compare
microsoft-github-policy-service
bot
added
emitter:client:java
radhgupta
force-pushed
the
maxpagesizeCasing
branch
from
2c458ff to
3cbd59b
Compare
Contributor
|
No changes needing a change description found. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request improves the handling of paging parameter names in the C# HTTP client generator to ensure consistent casing and backward compatibility with previous contracts. The update introduces logic to preserve the original casing of page size parameters if they exist in a previous contract, and to normalize common variants (like
maxpagesize) to a constant (maxPageSize) otherwise. Comprehensive tests are added to verify these behaviors.