Fix stack overflow for specs with large number of circular references

.chronus/changes/fix-stack-overflow-large-circular-refs-2026-1-6-16-3-35.md

@@ -0,0 +1,8 @@
+---
+# Change versionKind to one of: internal, fix, dependencies, feature, deprecation, breaking
+changeKind: fix
+packages:
+  - "@typespec/compiler"
+---
+
+Fix stack overflow for specs with large number of circular references

packages/compiler/src/core/name-resolver.ts

@@ -167,6 +167,7 @@ export function createResolver(program: Program): NameResolver {
   const augmentedSymbolTables = new Map<SymbolTable, SymbolTable>();
   const nodeLinks = new Map<number, NodeLinks>();
   const symbolLinks = new Map<number, SymbolLinks>();
+  const visitedNode = new Set<Node>();
 
   const globalNamespaceNode = createGlobalNamespaceNode();
   const globalNamespaceSym = createSymbol(
@@ -321,7 +322,6 @@ export function createResolver(program: Program): NameResolver {
     }
 
     let result = resolveTypeReferenceWorker(node, options);
-
     const resolvedSym = result.resolvedSymbol;
     Object.assign(links, result);
 
@@ -788,6 +788,7 @@ export function createResolver(program: Program): NameResolver {
       sym = node.symbol;
     }
     compilerAssert(sym, "Should have a symbol");
+
     links.resolvedSymbol = sym;
     links.resolutionResult = ResolutionResultFlags.Resolved;
   }
@@ -1217,6 +1218,15 @@ export function createResolver(program: Program): NameResolver {
   }
 
   function bindAndResolveNode(node: Node) {
+    if (visitedNode.has(node)) {
+      return;
+    }
+    visitedNode.add(node);
+
+    if ("id" in node && node.kind !== SyntaxKind.MemberExpression && node.id) {
+      bindDeclarationIdentifier(node as any);
+    }
+
     switch (node.kind) {
       case SyntaxKind.TypeReference:
         resolveTypeReference(node);
@@ -1248,11 +1258,6 @@ export function createResolver(program: Program): NameResolver {
       case SyntaxKind.CallExpression:
         resolveTypeReference(node.target);
         break;
-        break;
-    }
-
-    if ("id" in node && node.kind !== SyntaxKind.MemberExpression && node.id) {
-      bindDeclarationIdentifier(node as any);
     }
 
     visitChildren(node, bindAndResolveNode);

packages/compiler/test/regression/regression.test.ts

@@ -0,0 +1,14 @@
+import { readdirSync } from "fs";
+import { readFile } from "fs/promises";
+import { resolve } from "path";
+import { it } from "vitest";
+import { createTestRunner } from "../../src/testing/index.js";
+
+const specsDir = resolve(import.meta.dirname, "specs");
+const specFiles = readdirSync(specsDir).filter((f) => f.endsWith(".tsp"));
+
+it.each(specFiles)("%s", async (file) => {
+  const runner = await createTestRunner();
+  const content = await readFile(resolve(specsDir, file), "utf-8");
+  await runner.compile(content);
+});