Skip to content

Feature request: Extended ICancellationStrategy cancellation strategy #1326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
simon-curtis wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Feature request: Extended ICancellationStrategy cancellation strategy #1326

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/StreamJsonRpc/JsonRpc.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,10 +237,14 @@ public JsonRpc(IJsonRpcMessageHandler messageHandler, object? target)
/// Initializes a new instance of the <see cref="JsonRpc"/> class.
/// </summary>
/// <param name="messageHandler">The message handler to use to transmit and receive RPC messages.</param>
/// <param name="cancellationStrategy">
/// An optional cancellation strategy used to control how in-flight requests
/// are cancelled. If <see langword="null"/>, the default strategy <see cref="StandardCancellationStrategy"/> is used.
/// </param>
/// <remarks>
/// It is important to call <see cref="StartListening"/> to begin receiving messages.
/// </remarks>
public JsonRpc(IJsonRpcMessageHandler messageHandler)
public JsonRpc(IJsonRpcMessageHandler messageHandler, ICancellationStrategy? cancellationStrategy = null)
{
Requires.NotNull(messageHandler, nameof(messageHandler));

Expand All @@ -259,7 +263,7 @@ public JsonRpc(IJsonRpcMessageHandler messageHandler)
// If ordering is not required and higher throughput is desired, the owner of this instance can clear this property
// so that all incoming messages are queued to the threadpool, allowing immediate concurrency.
this.SynchronizationContext = new NonConcurrentSynchronizationContext(sticky: false);
this.CancellationStrategy = new StandardCancellationStrategy(this);
this.CancellationStrategy = cancellationStrategy ?? new StandardCancellationStrategy(this);
}

/// <summary>
Expand Down