Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4889
TODO:
Better description coming soon...
Will likely wait to merge this until after the next release cycle.
One quirk I had to handle here is that the site isn’t initialized yet when we first fetch resources, so I have to rely on the data model location returned by MS Graph (see westus and westus2). You’ll notice this location format differs from what we get when fetching directly from the ARM endpoint. Containerized Functions already has to do something similar for other reasons (see the Central US app).
I could make an additional ARM calls to retrieve the full site envelope and normalize the location format, but that would impact performance since it would no longer be lazily loaded. I chose to skip the extra fetch to preserve performance. In practice, the location is only needed to show when sites share the same name but are deployed to different regions.