Fix context key collision: agentSessionType and chatSessionType #292590
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both
ChatContextKeys.chatSessionTypeandChatContextKeys.agentSessionTypewere using the same underlying context key string'chatSessionType', causing ambiguity in context key resolution.Changes
Changed
agentSessionTypeto use distinct key string:All usages already reference the context key through the API (
.key,.isEqualTo(),.bindTo()), so no consumer changes required.Original prompt
ChatContextKeys.chatSessionType(line 65) andChatContextKeys.agentSessionType(line 103) use the same context key string'chatSessionType'. This creates ambiguity and can lead to unexpected behavior. TheagentSessionTypeexport should use a different key string, such as'agentSessionType'. #288692✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.