Fix/cli bugfixes #292602
Open
Fix/cli bugfixes #292602
+108
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@microsoft-github-policy-service agree |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes several real crash/edge-case bugs in the VS Code Rust CLI update + tunnel flows.
It prevents keychain credentials from becoming unreadable at exact chunk boundaries and stops msgpack RPC from spinning on EOF.
It removes a few panic paths in version detection, tunnel auth and log file setup by converting them into normal errors/warnings.
It also fixes update extraction crashes for small/empty zip/tar archives.
All changes are minimal, covered by added unit tests for the keychain boundary case and cargo clippy + cargo test pass.