Fix double update issue on Windows #292746
Draft
+80
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitrivMS
added
install-update
Contributor
There was a problem hiding this comment.
Pull request overview
This change adjusts the Windows update feed construction so that, when a specific pending commit is being overwritten, the update check can be targeted at that pending commit instead of always using the currently installed commit. This supports the overwrite/update machinery needed to avoid scenarios where a user effectively has to restart twice to land on the latest Insiders build.
Changes:
- Extend
Win32UpdateService.doCheckForUpdatesto accept an optionalpendingCommitparameter. - Use
pendingCommit ?? this.productService.commit!when building the Windows update feed URL so that, if a pending update commit is known, the server is queried as if that pending commit were the current version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #268531