Support serialized tool call results that return resources (e.g. rg, glob, etc) #292768
+100
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for serialized tool call results that return resources (URIs and Locations) by introducing a new ChatToolResourcesInvocationData type across the API surface and internal implementation.
Changes:
- Adds
ChatToolResourcesInvocationDatainterface to the proposed API with avaluesarray property - Updates internal types and union types to include
IChatToolResourcesInvocationData - Implements rendering logic to display resources as collapsible lists
- Adds accessibility support for screen readers
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/vscode-dts/vscode.proposed.chatParticipantAdditions.d.ts | Adds new ChatToolResourcesInvocationData interface to extension API with values: Array<Uri | Location> property |
| src/vs/workbench/contrib/chat/common/chatService/chatService.ts | Adds internal IChatToolResourcesInvocationData interface and updates union types in tool invocation interfaces |
| src/vs/workbench/contrib/chat/browser/widget/chatContentParts/toolInvocationParts/chatToolInvocationPart.ts | Implements rendering for resources tool data by reusing existing ChatResultListSubPart |
| src/vs/workbench/contrib/chat/browser/accessibility/chatResponseAccessibleView.ts | Adds accessibility descriptions for resources, formatting URIs and Locations for screen readers |
| src/vs/workbench/api/common/extHostTypeConverters.ts | Adds conversion logic from extension API types to internal types (contains critical bug) |
src/vs/workbench/contrib/chat/browser/accessibility/chatResponseAccessibleView.ts
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.