Fix isStringImplicitContextValue check (fixes selection context)
#292801
+4
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the isStringImplicitContextValue type guard function to properly validate StringChatContextValue objects. The function is used throughout the chat system to distinguish string-based implicit context values from other types like URIs and Locations.
Changes:
- Adds validation for the
resourceUrifield to ensure it's either undefined or a valid URI - Adds validation for the
handlefield to ensure it's a number (required by the interface) - Adds a check to ensure at least one of
nameorresourceUriis defined (though with incorrect logic)
jrieken
approved these changes
Feb 4, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.