PubSub: Allow custom encoder

[Ododo]

Hello.

I wanted to introduce this functionality because i needed the RedisManager to use Json instead of pickle for encoding data, so that other non-python applications listening to the redis channel can decode the data more easily.

I extended this to allow any encoder object to be used basically.

Thanks,

Olivier

[miguelgrinberg]

As far as I can see this PR is incomplete. You are decoding messages using the provided encoder, but you are not encoding with it.

[Ododo]

So there are 2 commits, one In the PubSubManager for decoding and the other for encoding in the RedisManager only (i tested only this).
Do you want me to add encoder parameters for all the manager classes ?

[miguelgrinberg]

This isn't necessary, right? The parent class also stores this attribute.

[Ododo]

right, thanks

[miguelgrinberg]

So there are 2 commits, one In the PubSubManager for decoding and the other for encoding in the RedisManager only (i tested only this).

Sorry, yes, I missed the RedisManager change.

Do you want me to add encoder parameters for all the manager classes ?

Yes, I want to have parity across these classes.

The build results also show that now there is a portion of the code that isn't covered by tests. Would you be able to address that as well?

[Ododo]

The build results also show that now there is a portion of the code that isn't covered by tests. Would you be able to address that as well?

Yes, will do.

[Ododo]

Hi @miguelgrinberg
I wanted to let you know that this PR is ready to be reviewed.

Kr