Remove object spread operator so old edge works#388
Open
Lego6245 wants to merge 1 commit intomikebryant:masterfrom
Open
Remove object spread operator so old edge works#388Lego6245 wants to merge 1 commit intomikebryant:masterfrom
Lego6245 wants to merge 1 commit intomikebryant:masterfrom
Conversation
Collaborator
|
Is this broken in Edge (Webkit)? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Old edge doesn't support the spread operator for object literals. We can make a simple one line change that use Object.assign instead which does basically the same thing, but allows for users still using old edge to use the site.
We should consider a transpile step to fix this class of issues automatically for devs (and potentially show a banner warning for browsers that aren't supported)
Fixes #383