10 Close other multiselects on open#15
Open
pgarrison wants to merge 1 commit intomiket-dev:masterfrom
Open
Conversation
We now use the `:focus-within` selector to handle opening & closing the dropdowns. * `:focus-within` is supported by all major browsers as of January 2020 * The global `hideMultiselects` function has been removed since we aren't using it. This is a breaking change, but it was never publicly documented and I don't see much use case for it anymore. In case someone was using `hideMultiselects`, they can now use `document.activeElement.blur()` instead.
|
@mneofit |
|
Damn thank you so much @pgarrison it saves my life ! :p |
Author
|
Since it seems like this repository is unmaintained, if anyone wants to continue development I am happy to add maintainers to my fork, though I am not actively working on it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We now use the
:focus-withinselector to handle opening & closing thedropdowns.
:focus-withinis supported by all major browsers as of January 2020hideMultiselectsfunction has been removed since wearen't using it. This is a breaking change, but it was never publicly
documented and I don't see much use case for it anymore. In case someone
was using
hideMultiselects, they can now usedocument.activeElement.blur()instead.Closes #10