[mangalib] added support #8404
Open
[mangalib] added support #8404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8294
Added support for mangalib.me, it seems to work on my machine (also added some tests)
There's one thing I'm not sure how to implement: every chapter can have multiple translations available, but I don't think that I should return all of them from MangaExtractor.chapters(), because that way chapter numbering would break (--chapter-range 1-2 will return two translations of the first chapter). So, for now I've hard-coded picking 1st translation automatically (which actually mangalib does, if you simply open chapter without specifying translation). But this way there's no way, for example, to download 1-10 chapters of team B, if team A also translated them.
That said, if user tries to download specific chapter with specific translation (bid specified in query params in chapter url), then it will download correct translation.
So I'm not sure, if there's a better solution, but if you have it, please let me know
Also, I wasn't able to implement auth, which is required for nsfw content (it seems like there's always captcha required for username/password auth, so I wasn't really trying).