feat: [ExternalTable Part4] Support data mapping for external collections#47730
Open
weiliu1031 wants to merge 5 commits intomilvus-io:masterfrom
Open
feat: [ExternalTable Part4] Support data mapping for external collections#47730weiliu1031 wants to merge 5 commits intomilvus-io:masterfrom
weiliu1031 wants to merge 5 commits intomilvus-io:masterfrom
Conversation
Contributor
Author
|
After Part3 is merged to master, please rebase this PR: git checkout part4_enable_data_mapping
git fetch upstream master
git rebase upstream/master
git push --force-with-leaseThis will clean up the commit history so only Part4-specific changes remain. |
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: weiliu1031 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
sre-ci-robot
added
area/dependency
Contributor
|
@weiliu1031 This is a feature PR ( How to resolve: Design documents location: https://github.com/milvus-io/milvus-design-docs/tree/main/design_docs |
mergify
bot
added
do-not-merge/missing-design-doc
kind/feature
Contributor
|
[ci-v2-notice] To rerun ci-v2 checks, comment with:
If you have any questions or requests, please contact @zhikunyao. |
Contributor
|
@weiliu1031 Please associate the related issue to the body of your Pull Request. (eg. "issue: #") |
…ctions issue: milvus-io#45881 This change introduces manual refresh capability for external collections, allowing users to trigger on-demand data synchronization from external sources. It replaces the legacy update mechanism with a more robust job-task hierarchy and persistent state management. Key changes: - Add RefreshExternalCollection, GetRefreshExternalCollectionProgress, and ListRefreshExternalCollectionJobs APIs across Client, Proxy, and DataCoord - Implement ExternalCollectionRefreshManager to manage refresh jobs with a 1:N Job-Task hierarchy - Add ExternalCollectionRefreshMeta for persistent storage of jobs and tasks in the metastore - Add ExternalCollectionRefreshChecker for task state management and worker assignment - Implement ExternalCollectionRefreshInspector for periodic job cleanup - Use WAL Broadcast mechanism for distributed consistency and idempotency - Replace legacy external_collection_inspector and update tasks with the new refresh-based implementation - Add comprehensive unit tests for refresh job lifecycle and state transitions Signed-off-by: Wei Liu <wei.liu@zilliz.com>
…nality - Add RefreshExternalCollectionOption tests in client - Add util key building tests for external refresh jobs/tasks - Add KV catalog tests for external collection refresh operations - Add MixCoord tests for refresh methods (refresh, progress, list) - Add distributed service tests for refresh RPC endpoints - Add distributed client tests for refresh operations All tests validate correct behavior of external collection manual refresh feature introduced in part3 enhancement. Signed-off-by: Wei Liu <wei.liu@zilliz.com>
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
…n cache miss fix - Add RefreshExternalCollection, GetRefreshExternalCollectionProgress, ListRefreshExternalCollectionJobs RPC forwarding to mixcoord client, service and proxy service layers - Register ExternalCollection task type in AppendType/GetTaskType - Replace direct meta lookup with collectionGetter callback in refresh manager to handle collection cache miss race condition - Replace CreateExternalCollection implementation with no-op stub - Regenerate mock_mixcoord and mock_mixcoord_client via make generate-mockery - Add unit tests for properties, proxy forwarding and no-op stub Signed-off-by: Wei Liu <wei.liu@zilliz.com>
…ions Implement the data mapping pipeline that converts external data files (Parquet) into Milvus segments with proper column mapping. Key changes: - Pre-allocate segment IDs in DataCoord, pass to DataNode for direct final-path manifest writes (eliminating two-phase ID workflow) - Add FFI bridges for file exploration (ExploreFiles, GetFileInfo) and manifest creation (CreateManifestForSegment, ReadFragmentsFromManifest) - Implement fragment-to-segment balancing with configurable target rows - Add ExternalSpec parser for external data format configuration - Extend UpdateExternalCollectionRequest proto with schema, storage config, and pre-allocated segment ID fields - Add E2E test for external collection refresh with data verification Signed-off-by: Jiquan Long <jiquan.long@zilliz.com> Signed-off-by: Wei Liu <wei.liu@zilliz.com>
weiliu1031
force-pushed
the
part4_enable_data_mapping
branch
from
301efc0 to
88014cf
Compare
Contributor
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #47730 +/- ##
===========================================
+ Coverage 74.12% 82.49% +8.37%
===========================================
Files 1452 614 -838
Lines 238922 98356 -140566
===========================================
- Hits 177091 81139 -95952
+ Misses 53686 17165 -36521
+ Partials 8145 52 -8093
🚀 New features to boost your workflow:
|
mergify
bot
removed
do-not-merge/missing-related-issue
do-not-merge/missing-design-doc
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
design doc: https://github.com/milvus-io/milvus-design-docs/blob/main/design_docs/20260105-external_table.md
issue: #45881
Summary
ExploreFiles,GetFileInfo) and manifest creation (CreateManifestForSegment,ReadFragmentsFromManifest)ExternalSpecparser for external data format configurationUpdateExternalCollectionRequestproto with schema, storage config, and pre-allocated segment ID fieldsTest plan
task_refresh_external_collection.go(28 tests)task_update.goand fragment utilities (40 tests)exttable_test.go, 9 tests)ExternalSpecparsermake lint-fixpasses