Skip to content

enhance: add trace for search pipeline(#47731)#47736

Open
MrPresent-Han wants to merge 1 commit intomilvus-io:masterfrom
MrPresent-Han:trace-groupby-debug
Open

enhance: add trace for search pipeline(#47731)#47736
MrPresent-Han wants to merge 1 commit intomilvus-io:masterfrom
MrPresent-Han:trace-groupby-debug

Conversation

@MrPresent-Han
Copy link
Contributor

related: #47731

@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. area/test sig/testing labels Feb 11, 2026
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Feb 11, 2026
@sre-ci-robot
Copy link
Contributor

[ci-v2-notice]
Notice: New ci-v2 system is enabled for this PR.

To rerun ci-v2 checks, comment with:

  • /ci-rerun-code-check // for ci-v2/code-check
  • /ci-rerun-build // for ci-v2/build
  • /ci-rerun-build-all // for ci-v2/build-all (multi-arch builds)
  • /ci-rerun-ut-integration // for ci-v2/ut-integration, will rerun ci-v2/build
  • /ci-rerun-ut-go // for ci-v2/ut-go, will rerun ci-v2/build
  • /ci-rerun-ut-cpp // for ci-v2/ut-cpp
  • /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp, will rerun ci-v2/build
  • /ci-rerun-e2e-arm // for ci-v2/e2e-arm
  • /ci-rerun-e2e-default // for ci-v2/e2e-default

If you have any questions or requests, please contact @zhikunyao.

@sre-ci-robot sre-ci-robot added the low-code-coverage add test-label from zhikun, diff coverage > 80% label Feb 11, 2026
@codecov
Copy link

codecov bot commented Feb 11, 2026

Codecov Report

❌ Patch coverage is 56.27706% with 101 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.67%. Comparing base (1f49934) to head (70c5df6).
⚠️ Report is 21 commits behind head on master.

⚠️ Current head 70c5df6 differs from pull request most recent head 83a82d6

Please upload reports for the commit 83a82d6 to get more accurate results.

Files with missing lines Patch % Lines
internal/proxy/pipeline_trace.go 50.24% 95 Missing and 6 partials ⚠️

❌ Your patch check has failed because the patch coverage (56.27%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.
❌ Your project check has failed because the head coverage (76.67%) is below the target coverage (77.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #47736      +/-   ##
==========================================
- Coverage   76.71%   76.67%   -0.05%     
==========================================
  Files        2054     2055       +1     
  Lines      334563   334959     +396     
==========================================
+ Hits       256651   256815     +164     
- Misses      69783    69983     +200     
- Partials     8129     8161      +32     
Components Coverage Δ
Client 78.70% <100.00%> (+0.23%) ⬆️
Core 83.22% <98.27%> (+0.01%) ⬆️
Go 74.89% <57.74%> (-0.09%) ⬇️
Files with missing lines Coverage Δ
internal/core/src/segcore/reduce/GroupReduce.cpp 94.89% <100.00%> (+0.10%) ⬆️
internal/proxy/search_pipeline.go 81.09% <100.00%> (+0.06%) ⬆️
internal/proxy/search_reduce_util.go 78.75% <100.00%> (+0.04%) ⬆️
internal/proxy/task.go 77.87% <ø> (ø)
internal/proxy/task_search.go 69.65% <100.00%> (+0.13%) ⬆️
internal/querynodev2/delegator/delegator.go 84.74% <100.00%> (+0.10%) ⬆️
internal/util/function/rerank/util.go 84.70% <100.00%> (+0.33%) ⬆️
internal/proxy/pipeline_trace.go 50.24% <50.24%> (ø)

... and 35 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mergify
Copy link
Contributor

mergify bot commented Feb 11, 2026

@MrPresent-Han Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@mergify mergify bot added needs-dco DCO is missing in this pull request. and removed dco-passed DCO check passed. labels Feb 11, 2026
@mergify
Copy link
Contributor

mergify bot commented Feb 11, 2026

@MrPresent-Han go-sdk check failed, comment rerun go-sdk can trigger the job again.

@sre-ci-robot sre-ci-robot added size/XL Denotes a PR that changes 500-999 lines. and removed size/L Denotes a PR that changes 100-499 lines. labels Feb 12, 2026
@mergify mergify bot added dco-passed DCO check passed. and removed needs-dco DCO is missing in this pull request. labels Feb 12, 2026
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: MrPresent-Han
To complete the pull request process, please assign yanliang567 after the PR has been reviewed.
You can assign the PR to them by writing /assign @yanliang567 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…ilvus-io#47731)

Add a diagnostic trace mechanism that records critical variable states
after each search pipeline operator (reduce, rerank, requery, organize,
end). Enabled via `pipeline_trace=true` search param with zero overhead
when disabled. Traces per-nq groupBy cardinality and contiguity to help
diagnose cases where unique group count deviates from expected limit.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: MrPresent-Han <chun.han@gmail.com>
@sre-ci-robot sre-ci-robot removed the low-code-coverage add test-label from zhikun, diff coverage > 80% label Feb 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/test dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement sig/testing size/XL Denotes a PR that changes 500-999 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants