add jit #25
Open
add jit #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add @jit decorator to LlamaModelEagle3.construct to enable static graph mode - Add set_model_inputs method to declare dynamic shapes for inputs - This allows MindSpore static graph compiler to handle Eagle3's dynamic batch sizes properly
…ecode graphs Problem: - Original implementation used @jit decorator on construct methods, causing control flow statements (is_prefill, capture_hidden_mode, forward_mode conditions) to be compiled into static graph, resulting in 6 sub-graphs and triggering "multi sub graph" error Solution: - Reference vllm-mindspore qwen2_eagle3 implementation - Remove @jit decorators and implement exec_model to compile and cache separate prefill_graph and decode_graph based on is_prefill flag - Each compiled graph has no control flow, meeting MindSpore static graph optimization requirements
Problem:
- LlamaAttention.construct has if is_prefill branch (llama.py)
- When is_prefill passed as parameter, control flow is compiled into graph
Solution:
- Remove is_prefill parameter from LlamaDecoderLayerEagle3.attention call
- Rely on get_model_context("is_prefill") inside LlamaAttention
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.