fix: let v' shortcut use main browser in Safari PWA #4008
Merged
+2
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fguillot
reviewed
Feb 9, 2026
When using the 'v' shortcut in a Safari PWA on macOS, Miniflux opened the link in something similar to an 'in-app browser' with no URL bar and a separate window for each link. When clicking the link with the mouse, a "normal" browser tab is opened instead. It looks like target="_blank" on the <a> element implies the "noopener" attribute, which causes Safari to use the main browser. For window.open, "noopener" is not implied. This commit adds the "noreferrer" argument to the window.open call (which implies the "noopener" option) rather than changing the window.opener attribute manually. This option causes Safari to use the main browser with the 'v' shortcut.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the 'v' shortcut in a Safari PWA on macOS, Miniflux opened the link in something similar to an 'in-app browser' with no URL bar and a separate window for each link. When clicking the link with the mouse, a "normal" browser tab is opened instead.
It looks like
target="_blank"on the element implies the"noopener"attribute, which causes Safari to use the main browser. For window.open,"noopener"is not implied. This commit adds the"noreferrer"argument to the window.open call (which implies the"noopener"option) rather than changing thewindow.openerattribute manually. This option causes Safari to use the main browser with the 'v' shortcut.Have you followed these guidelines?