perf(parser): don't process the whole page to detect its format#4058
Merged
fguillot merged 1 commit intominiflux:mainfrom Feb 14, 2026
Merged
perf(parser): don't process the whole page to detect its format#4058fguillot merged 1 commit intominiflux:mainfrom
fguillot merged 1 commit intominiflux:mainfrom
Conversation
There is no need to process the whole page to guess its format: if we can't find a format indicator in the first 50 xml tokens, odds are that we won't find it at all. This should save some time when trying to find a feed, as this function is called a handful of times on various pages.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no need to process the whole page to guess its format: if we can't find a format indicator in the first 50 xml tokens, odds are that we won't find it at all.
This should save some time when trying to find a feed, as this function is called a handful of times on various pages.