perf(readability): small performance improvements#4059
Open
jvoisin wants to merge 1 commit intominiflux:mainfrom
Open
perf(readability): small performance improvements#4059jvoisin wants to merge 1 commit intominiflux:mainfrom
jvoisin wants to merge 1 commit intominiflux:mainfrom
Conversation
Collaborator
jvoisin
commented
Feb 13, 2026
jvoisin
commented
- Don't create a string by concatenation on the heap to then pass it to a strings.Builder, pass everything, one by one, to it instead.
- Lower the complexity of shouldRemoveCandidate from quadratic to linear.
- Don't create a string by concatenation on the heap to then pass it to a strings.Builder, pass everything, one by one, to it instead. - Lower the complexity of shouldRemoveCandidate from quadratic to linear.
fguillot
reviewed
Feb 14, 2026
| isFalsePositive := false | ||
| for _, maybeCandidateToRemove := range maybeCandidateToRemove { | ||
| if strings.Contains(str, maybeCandidateToRemove) { | ||
| isFalsePositive = true |
Member
There was a problem hiding this comment.
@jvoisin you can break the loop the first time it's true
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.