Use relative paths for imports in bundled shiki worker#192
Closed
lindsayzhng wants to merge 2 commits intomainfrom
Closed
Use relative paths for imports in bundled shiki worker#192lindsayzhng wants to merge 2 commits intomainfrom
lindsayzhng wants to merge 2 commits intomainfrom
Conversation
Contributor
Author
|
not needed anymore |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
the bundled worker doesn't recognize the vite alias imports, so they need to be relative
Test Plan
tested locally
Note
Medium Risk
Touches syntax-highlighting behavior and worker loading paths; regressions could impact rendering performance or highlighting availability for large code blocks, but changes are localized.
Overview
Fixes the bundled Shiki worker failing to resolve Vite alias imports by switching its dynamic imports to relative module paths (e.g.,
./constants.js,./get-code-styling.js,./snippet-presets.js).Refines
getShikiHighlightedHtmllarge-input behavior: skips highlighting for extremely large blocks (>MAX_PREVIEW_BYTES * 5), prefers the worker for inputs >MAX_PREVIEW_BYTESwhen async is allowed, and if the worker path fails it now falls back to synchronous highlighting instead of returningundefined.Written by Cursor Bugbot for commit 1ab14d4. This will update automatically on new commits. Configure here.