This repository was archived by the owner on Jul 15, 2024. It is now read-only.
await res.json() がコケることがあるのでtry catchする#57
Open
fruitriin wants to merge 1 commit intomisskey-dev:developfrom
Open
await res.json() がコケることがあるのでtry catchする#57fruitriin wants to merge 1 commit intomisskey-dev:developfrom
fruitriin wants to merge 1 commit intomisskey-dev:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
misskey.js の client が request するとき、 jsonが帰ってくることを期待せず、jsonでなければなんか適当にメッセージをrejectする
Why
misskey.js の client が request するとき、CDNなどの都合でHTMLなどが帰ってくることがある。
この場合、Promise が reject となるわけではないので、 then節へ突入する。status code は200とか204だったりする。
すると .json() したときに JSON.parse() すると例外を発生させるが、これは実行時例外となりどこにもcatchされない
Unexpected token "<" って出てるヤツがこれ
requestの中で発生しているため使う側でtry catch してもでてくるのでなんかしら対処は必要な認識
Additional info (optional)