CSS theme cleanup: Replace duplicate light/dark palette methods with one theme config.#2186
Open
Gitjay11 wants to merge 1 commit intomito-ds:devfrom
Open
CSS theme cleanup: Replace duplicate light/dark palette methods with one theme config.#2186Gitjay11 wants to merge 1 commit intomito-ds:devfrom
Gitjay11 wants to merge 1 commit intomito-ds:devfrom
Conversation
…EME_CONFIG object
|
@Gitjay11 is attempting to deploy a commit to the trymito Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes Theme CSS Cleanup #2170
palettes.ts used to have two separate methods, [setColorsLight] and [setColorsDark] , that did the same thing with a long list of repeated
style.setProperty(...)calls. That meant the same CSS variable names were written twice which made it easy to accidentally update one theme and forget the other. This change moves all theme variables into one configuration object that stores both the light and dark values, and a single helper applies the correct set depending on the theme. As a result, the light and dark themes stay consistent, the code is shorter and adding or changing a theme variable only needs to be done in one place.Testing
Documentation
No documentation changes required.