Set GL_DEPTH_BUFFER_BIT when blitting the depth buffer to the screen.#126
Open
LukasRuppert wants to merge 2 commits intomitsuba-renderer:masterfrom
Open
Set GL_DEPTH_BUFFER_BIT when blitting the depth buffer to the screen.#126LukasRuppert wants to merge 2 commits intomitsuba-renderer:masterfrom
LukasRuppert wants to merge 2 commits intomitsuba-renderer:masterfrom
Conversation
wjakob
force-pushed
the
master
branch
11 times, most recently
from
e9c6fc9 to
0f47fe0
Compare
LukasRuppert
force-pushed
the
fix_deph_buffer_blit
branch
2 times, most recently
from
6c85fd3 to
2b9f30a
Compare
(Fixes a copy-paste bug, previously the GL_STENCIL_BUFFER_BIT was being set.)
LukasRuppert
force-pushed
the
fix_deph_buffer_blit
branch
from
2b9f30a to
3e7b788
Compare
…ing is enabled in the texture. (Blitting a multisampled texture into a single-sample screen results in a GL_INVALID_OPERATION.) Should there be a warning if blitting is not possible?
LukasRuppert
force-pushed
the
fix_deph_buffer_blit
branch
from
3e7b788 to
de3221f
Compare
wjakob
force-pushed
the
master
branch
9 times, most recently
from
654b8a5 to
1cbff2e
Compare
wjakob
force-pushed
the
master
branch
4 times, most recently
from
a634dc0 to
32f7bed
Compare
wjakob
force-pushed
the
master
branch
21 times, most recently
from
c75898b to
1bbd038
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I just had a look through the code and found what looks like a simple copy-paste bug.
When blitting to the screen, the stencil bit would be set instead of the depth buffer bit.