Skip to content

fix(CartesianChart): refactor chart#2309

Merged
ins0 merged 10 commits intomainfrom
fix/CartesianChart
Feb 10, 2026
Merged

fix(CartesianChart): refactor chart#2309
ins0 merged 10 commits intomainfrom
fix/CartesianChart

Conversation

@ins0
Copy link
Member

@ins0 ins0 commented Feb 10, 2026

fixes #2195
fixes emptyView is not visible in remote context
fixes grid is not removed in remote context when empty
fixes chart is not visible when height is empty

removed data prop that is passed to emptyView since it is always empty

@github-actions
Copy link
Contributor

github-actions bot commented Feb 10, 2026

Coverage Report for ./packages/components/

Status Category Percentage Covered / Total
🔵 Lines 82.24% 264 / 321
🔵 Statements 82.56% 270 / 327
🔵 Functions 89.85% 62 / 69
🔵 Branches 71.34% 122 / 171
File CoverageNo changed files found.
Generated in workflow #4708 for commit 4d892ed by the Vitest Coverage Report Action

@ins0 ins0 added the update-screenshots Label a PR to update the screenshots used for visual regression testing label Feb 10, 2026
@mfal mfal removed the update-screenshots Label a PR to update the screenshots used for visual regression testing label Feb 10, 2026
@ins0 ins0 changed the title Fix(CartesianChart): refactor chart fix(CartesianChart): refactor chart Feb 10, 2026
@ins0 ins0 added the update-screenshots Label a PR to update the screenshots used for visual regression testing label Feb 10, 2026
@mfal mfal removed the update-screenshots Label a PR to update the screenshots used for visual regression testing label Feb 10, 2026
Co-authored-by: ins0 <2622534+ins0@users.noreply.github.com>
@mfal mfal removed the update-screenshots Label a PR to update the screenshots used for visual regression testing label Feb 10, 2026
Co-authored-by: ins0 <2622534+ins0@users.noreply.github.com>
@ins0 ins0 merged commit dbf2adb into main Feb 10, 2026
4 checks passed
@ins0 ins0 deleted the fix/CartesianChart branch February 10, 2026 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

EmptyView shifts off-center after window or display resize

3 participants