fix: readiness probe check moved to background#413
Open
imightbuyaboat wants to merge 3 commits intomittwald:masterfrom
Open
fix: readiness probe check moved to background#413imightbuyaboat wants to merge 3 commits intomittwald:masterfrom
imightbuyaboat wants to merge 3 commits intomittwald:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To test the issue, a configmap of the following type was created:
and 200 namespaces of the following type:
When a large number of field changes were made to the original configmap, the replicator couldn't synchronize the configmap within 60 seconds when calling the readiness probe handler. Because of this, the readiness probe check failed, and the replicator restarted:
Logs of replicator:
As a solution to the problem, replicator synchronization is moved to a background process, which writes the result to the
notReadyvariable, and the readiness probe handler takes the values fromnotReadyand returns them when requested.The
-components-sync-periodparameter has also been added to specify the time interval after which replicator synchronization will occur.