Conversation
This version of MD_PARSER changes prototypes of callbacks enter_block(), leave_block(), enter_span(), leave_span() and text() so that their 1st argument is int instead of enumerations MD_BLOCK_TYPE, MD_SPAN_TYPE and MD_TEXT_TYPE respectivelly. The purpose if this is to enable introduction of new block, span and text type in runtime in upcoming patches.
Also update md2html to enable this on the parser side rather than renderer side. Make MD_HTML_FLAG_SKIP_UTF8_BOM deprecated. md_html() converts the flag into parser_flags.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #249 +/- ##
==========================================
- Coverage 91.74% 91.44% -0.30%
==========================================
Files 5 5
Lines 3366 3389 +23
Branches 764 765 +1
==========================================
+ Hits 3088 3099 +11
- Misses 278 290 +12 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is an attempt to implement the proposal discussed in #245.
Rough to-do list:
md4c.hso that the callbacks can get custom block/span/text type IDs.md4c-html.hso that application can override the output of the HTML renderer for some block/span/text types.MD_PARSERso that it's possible to add support for new custom span ranges.md2html(e.g. subscript, superscript)MD_PARSERso that it's possible to add support for new custom auto-ending spans (name-like).md2html(e.g. feature idea: named emoji like:wink:#183 and/or user mentions).