Skip to content

fix OFF_MAX redefinition and a potential overflow#286

Open
acmepjz wants to merge 1 commit intomity:masterfrom
acmepjz:acmepjz_fix_off_max
Open

fix OFF_MAX redefinition and a potential overflow#286
acmepjz wants to merge 1 commit intomity:masterfrom
acmepjz:acmepjz_fix_off_max

Conversation

@acmepjz
Copy link

@acmepjz acmepjz commented Jun 11, 2025

This addresses first two points of issue #281.

  • Since OFF_MAX is not used in the code at all, I just remove it.
  • SZ_MAX is used only at one place in the code, and 1024 * 1024 is always smaller than it, so it seems redundant.
  • 16 * size could overflow, which makes the MIN returns 0 which is unwanted. I've changed the code such that if that happens, it also returns 1024 * 1024.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant