fix OFF_MAX redefinition and a potential overflow#286
Open
acmepjz wants to merge 1 commit intomity:masterfrom
Open
fix OFF_MAX redefinition and a potential overflow#286acmepjz wants to merge 1 commit intomity:masterfrom
acmepjz wants to merge 1 commit intomity:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses first two points of issue #281.
OFF_MAXis not used in the code at all, I just remove it.SZ_MAXis used only at one place in the code, and1024 * 1024is always smaller than it, so it seems redundant.16 * sizecould overflow, which makes theMINreturns0which is unwanted. I've changed the code such that if that happens, it also returns1024 * 1024.