Add backport for 'OR' constraint mode#111
Open
LeComptoirDesPharmacies wants to merge 1 commit intomkurz:2.5.xfrom
Open
Add backport for 'OR' constraint mode#111LeComptoirDesPharmacies wants to merge 1 commit intomkurz:2.5.xfrom
LeComptoirDesPharmacies wants to merge 1 commit intomkurz:2.5.xfrom
Conversation
Owner
|
Hi Le Comptoir Des Pharmacies (@LeComptoirDesPharmacies)! is this pull request still needed? Looking at https://github.com/LeComptoirDesPharmacies/lcdp-deadbolt-extension-java/blob/master/deadbolt-java-extension/pom.xml#L18-L19 it seems you already upgraded to the latest deadbolt version anyway... I will release a new deadbolt version with Play 2.9 and 3.0 support soon. BTW: Congratulations to your recent funding round of 3,5mio EUR 👍 May I ask if you would be able to become sponsor of the Play Framework? (see https://www.playframework.com/sponsors and https://opencollective.com/playframework)? Best, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to add backport for 'OR' constraint mode (https://github.com/schaloner/deadbolt-2-java/pull/50/files) compatible with version 2.5.x of deadbolt