Show session age in the "detached Mosh sessions" warning#1361
Open
eminence wants to merge 1 commit intomobile-shell:masterfrom
Open
Show session age in the "detached Mosh sessions" warning#1361eminence wants to merge 1 commit intomobile-shell:masterfrom
eminence wants to merge 1 commit intomobile-shell:masterfrom
Conversation
Previously, the message just told you the pid of the detached mosh session:
- mosh [3892360]
But this doesn't immediately give you any hints about if this is an ancient
session that's clearly from a dead process or not.
Now it looks like this:
- mosh [3892360] (age 58d 11h 5m)
Now it's more obvious if this session is part of a stale session or not
811f454 to
620dd55
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the message just told you the pid of the detached mosh session:
But this doesn't immediately give you any hints about if this is an ancient session that's clearly from a dead process or not.
Now it looks like this:
This change may reduce confusion that sometimes appears in issues like #394
Now it's more obvious if this session is part of a stale session or not