Skip to content

dockerfile: promote --parents flag from labs#6282

Merged
tonistiigi merged 1 commit intomoby:masterfrom
jsternberg:promote-parents-from-labs
Nov 5, 2025
Merged

dockerfile: promote --parents flag from labs#6282
tonistiigi merged 1 commit intomoby:masterfrom
jsternberg:promote-parents-from-labs

Conversation

@jsternberg
Copy link
Collaborator

@jsternberg jsternberg commented Oct 9, 2025

No description provided.

@jsternberg jsternberg force-pushed the promote-parents-from-labs branch from 7e47318 to 87e7250 Compare October 23, 2025 19:09
@jsternberg jsternberg marked this pull request as ready for review October 23, 2025 19:19
@jsternberg jsternberg requested a review from tonistiigi October 23, 2025 19:19
@jsternberg jsternberg force-pushed the promote-parents-from-labs branch 2 times, most recently from 5c0cf2f to 8a78533 Compare October 24, 2025 18:42
tonistiigi
tonistiigi previously approved these changes Oct 24, 2025
View reviewed changes
@jsternberg jsternberg force-pushed the promote-parents-from-labs branch 2 times, most recently from b5cf692 to e7b2c0c Compare October 27, 2025 16:59
tonistiigi
tonistiigi reviewed Oct 27, 2025
View reviewed changes
cache/contenthash/checksum.go Outdated

// Validate that all required paths exist.
for _, requiredPath := range opts.RequiredPaths {
requiredPath = filepath.ToSlash(requiredPath)
Copy link
Member

@tonistiigi tonistiigi Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this would be the right place for such fix. General rule is that LLB layer should have all the paths already in unix-style. If the client is working with Windows paths, then they convert them to Unix before LLB marshal, and if the wcow daemon needs a Windows path for local file operations, then they convert it from Unix to the local format.

cc @profnandaa

Copy link
Collaborator Author

@jsternberg jsternberg Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't seem to have worked anyway.

@jsternberg jsternberg force-pushed the promote-parents-from-labs branch from e7b2c0c to 2670f2a Compare October 27, 2025 17:58
@jsternberg jsternberg marked this pull request as draft October 27, 2025 17:58
@jsternberg
Copy link
Collaborator Author

jsternberg commented Oct 27, 2025

Switching this to draft until I fix the windows test. It appears we didn't run the labs tests on windows so this popped up here instead.

@tonistiigi tonistiigi dismissed their stale review October 27, 2025 20:01

wcow failing

@jsternberg jsternberg force-pushed the promote-parents-from-labs branch from 2670f2a to bf172e6 Compare October 27, 2025 20:22
@jsternberg
Copy link
Collaborator Author

jsternberg commented Oct 27, 2025

I made changes for normalizing the file path but when I attempted to update the integration test to work on Windows I didn't find any other examples of writing a windows command prompt test in such a way so I marked it as skipped for now. Similar tests were also skipped on Windows.

@tonistiigi
Copy link
Member

tonistiigi commented Oct 27, 2025

cc @rzlink

@jsternberg jsternberg marked this pull request as ready for review October 28, 2025 01:46
@jsternberg jsternberg force-pushed the promote-parents-from-labs branch from bf172e6 to f26e9ee Compare October 30, 2025 16:19
@jsternberg jsternberg force-pushed the promote-parents-from-labs branch 2 times, most recently from be93820 to 5ad85a8 Compare October 30, 2025 18:55
@jsternberg jsternberg force-pushed the promote-parents-from-labs branch 4 times, most recently from 08a1617 to 752d3af Compare October 30, 2025 20:36
@jsternberg jsternberg force-pushed the promote-parents-from-labs branch 4 times, most recently from f2dea0c to ec04db4 Compare October 31, 2025 15:08
@jsternberg
Copy link
Collaborator Author

jsternberg commented Oct 31, 2025

@profnandaa @rzlink I'm having some issues trying to get a windows version of this test working. I'm getting this error: a decent amount

  sandbox.go:205: time="2025-10-31T15:22:45Z" level=error msg="/moby.buildkit.v1.Control/Solve returned error: rpc error: code = Unknown desc = failed to read C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\buildkit-mount2968917312\\System Volume Information: open \\System Volume Information: Access is denied." spanID=0140e0b624168def traceID=aa3abf39e6dd9193c5ae270a8c9129d9
    sandbox.go:205: failed to read C:\Users\RUNNER~1\AppData\Local\Temp\buildkit-mount2968917312\System Volume Information: open \System Volume Information: Access is denied.

I assumed it had something to do with the container user so I tried changing the user to ContainerAdministrator in all of the stages. I also tried getting rid of any heredoc lines from the test. I was curious if one of you two could take a look at the test and identify what I might be doing wrong.

@tonistiigi tonistiigi added this to the v0.26.0 milestone Nov 5, 2025
@jsternberg
dockerfile: promote --parents flag from labs
98d0a0a 
Signed-off-by: Jonathan A. Sternberg <jonathan.sternberg@docker.com>
@jsternberg jsternberg force-pushed the promote-parents-from-labs branch from ec04db4 to 98d0a0a Compare November 5, 2025 18:52
@jsternberg jsternberg mentioned this pull request Nov 5, 2025
Closed
@tonistiigi tonistiigi merged commit 079060b into moby:master Nov 5, 2025
170 of 171 checks passed
@jsternberg jsternberg deleted the promote-parents-from-labs branch November 5, 2025 20:51
@jedevc jedevc mentioned this pull request Jan 22, 2026
Merged
rcdailey added a commit to recyclarr/recyclarr that referenced this pull request Jan 23, 2026
@rcdailey
chore(docker): remove explicit dockerfile syntax directive
19d437a 
The -labs channel was required for COPY --parents, which graduated
to stable in dockerfile 1.20.0 (moby/buildkit#6282).

Removing the syntax directive entirely lets Docker use its built-in
BuildKit frontend, avoiding version drift and stale cached images.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tonistiigi tonistiigi tonistiigi approved these changes

Assignees

@jsternberg jsternberg

Labels

area/dockerfile area/docs area/frontend area/project area/testing

Projects

None yet

Milestone

v0.26.0

Development

Successfully merging this pull request may close these issues.

2 participants

@jsternberg @tonistiigi