Impose a limit of 4k on HTTP headers and request lines#379
Open
djs55 wants to merge 3 commits intomoby:masterfrom
Open
Impose a limit of 4k on HTTP headers and request lines#379djs55 wants to merge 3 commits intomoby:masterfrom
djs55 wants to merge 3 commits intomoby:masterfrom
Conversation
This imports mirage/mirage-channel#25 Signed-off-by: David Scott <dave.scott@docker.com>
This imports mirage/ocaml-cohttp#612 Signed-off-by: David Scott <dave.scott@docker.com>
Signed-off-by: David Scott <dave.scott@docker.com>
akimd
approved these changes
May 17, 2018
Contributor
akimd
left a comment
akimd
left a comment
There was a problem hiding this comment.
I'm incompetent to review this, you'll know better :) I saw nothing weird (but have no idea what ASN.1 is doing here...).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In case someone pipes large amounts of binary junk through the proxy, we impose a 4k limit on line length. Unfortunately we will send back a miscellaneous 500 server error rather than the correct 413 Entity too large, but this is better than nothing.
read_linemirage/mirage-channel#25