Open
Conversation
Added test namespace to Composer autoloader.
Collaborator
|
As mentioned on IRC in regards to BC, anyone currently cloning a Mockery mock would have to fix up their tests: <?php
require "vendor/autoload.php";
class Foo {
function __clone() {}
}
$double = Mockery::mock(Foo::class);
$second = clone ($double);
// PHP Fatal error: Uncaught BadMethodCallException: Received Mockery_0_Foo::__clone(), but no expectations were specified in /Users/davem/src/mockery/library/Mockery/Loader/EvalLoader.php(34) : eval()'d code:774You mentioned |
|
hi, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There does not seem to be any compelling reason why void magic methods such
__construct,__destructor__cloneshould not be mockable. However, this PR only seeks to add__clonesupport.As a bonus, added test namespace (
MockeryTest) to Composer autoloader to save manually including test fixtures (and other test files) in tests.Resolves #669.