[Fix] fix input_audio wrong prefix (modelscope/evalscope#1152)#1174
[Fix] fix input_audio wrong prefix (modelscope/evalscope#1152)#1174Yunnglin merged 1 commit intomodelscope:mainfrom
Conversation
Summary of ChangesHello @labAxiaoming, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves a critical issue where audio data was being sent with an incorrect prefix when processed for Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
您好,感谢您的贡献。本次变更旨在修复 input_audio 错误的前缀问题。通过将 file_as_data_uri 替换为 data_uri_to_base64 来移除 data URI 的前缀。然而,这个修改引入了一个潜在的 bug:当 content.audio 是文件路径而非 data URI 时,data_uri_to_base64 会直接返回文件路径,而不是预期的 base64 编码数据。我已在代码中提出了修改建议,以确保在移除前缀之前,文件路径能被正确地转换为 data URI。
Update evalscope/models/utils/openai.py Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
3e1553f to
87168aa
Compare
Yunnglin
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the contribution. Merging now.
解决 vllm 跑 audio 数据集,前缀问题
#1152
vllm-project/vllm#32636