Skip to content

[Fix] fix input_audio wrong prefix (modelscope/evalscope#1152)#1174

Merged
Yunnglin merged 1 commit intomodelscope:mainfrom
labAxiaoming:main_audio
Jan 30, 2026
Merged

[Fix] fix input_audio wrong prefix (modelscope/evalscope#1152)#1174
Yunnglin merged 1 commit intomodelscope:mainfrom
labAxiaoming:main_audio

Conversation

@labAxiaoming
Copy link
Contributor

解决 vllm 跑 audio 数据集,前缀问题

#1152
vllm-project/vllm#32636

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @labAxiaoming, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a critical issue where audio data was being sent with an incorrect prefix when processed for input_audio parameters, specifically impacting compatibility with vllm for audio datasets. The change involves switching the data processing utility to ensure the input_audio parameter receives correctly formatted base64 data, thereby enabling proper functionality.

Highlights

  • Audio Data Processing Fix: The openai_chat_completion_part function was updated to correctly handle audio data. The previous file_as_data_uri call, which caused an incorrect prefix, has been replaced with data_uri_to_base64. This ensures that the input_audio parameter receives properly formatted base64 encoded data, resolving compatibility issues with vllm.
  • New Utility Import: The data_uri_to_base64 function has been imported from evalscope.utils.url_utils to support the revised audio data processing logic.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

您好,感谢您的贡献。本次变更旨在修复 input_audio 错误的前缀问题。通过将 file_as_data_uri 替换为 data_uri_to_base64 来移除 data URI 的前缀。然而,这个修改引入了一个潜在的 bug:当 content.audio 是文件路径而非 data URI 时,data_uri_to_base64 会直接返回文件路径,而不是预期的 base64 编码数据。我已在代码中提出了修改建议,以确保在移除前缀之前,文件路径能被正确地转换为 data URI。

Update evalscope/models/utils/openai.py

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Copy link
Collaborator

@Yunnglin Yunnglin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the contribution. Merging now.

@Yunnglin Yunnglin merged commit b419590 into modelscope:main Jan 30, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

测 audio 报错,似乎把 "data:audio/wav;base64," 也拿去编码了, 导致长度不是4的倍数,要去掉

2 participants