FIX-#7638: Suppress default to pandas warnings on native pandas backend #7639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-joshi
requested review from
a team,
RehanSD,
YarShev,
anmyachev,
dchigarev,
devin-petersohn,
mvashishtha and
vnlitvinov
as code owners
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
sfc-gh-mvashishtha
approved these changes
Aug 1, 2025
Contributor
sfc-gh-mvashishtha
left a comment
sfc-gh-mvashishtha
left a comment
There was a problem hiding this comment.
one optional comment
sfc-gh-joshi
force-pushed
the
joshi/checked-default
branch
from
d76b1ed to
e39d164
Compare
| The reason for defaulting. | ||
| """ | ||
| # Avoids a module-level circular import | ||
| from modin.core.execution.dispatching.factories.dispatcher import FactoryDispatcher |
Check notice
Code scanning / CodeQL
Cyclic import Note
…tive pandas backend Signed-off-by: Jonathan Shi <jonathan.shi@snowflake.com>
sfc-gh-joshi
force-pushed
the
joshi/checked-default
branch
from
5e214ce to
537ccbf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
IO and general module functions now all share a code path that checks whether the active backend's query compiler should warn on default to pandas. Methods that default to pandas directly in the base.py frontend layer (rather than at the query compiler level) also now use this code path.
flake8 modin/ asv_bench/benchmarks scripts/doc_checker.pyblack --check modin/ asv_bench/benchmarks scripts/doc_checker.pygit commit -sdocs/development/architecture.rstis up-to-date