[driver] SSD1306 SPI display by rleh · Pull Request #1090 · modm-io/modm

rleh · 2023-10-09T23:57:02Z

Rename modm::Ssd1306 to Ssd1306I2c
Add modm::Ssd1306Spi
- Initialize sequence for 128x32px, 0.91inch, blue, HP12832-02 display module
Convert all enums in struct modm::ssd1306 to enum class
Fix mistake in SH1106 driver
Add example for (existing) SH1106 driver

rleh · 2023-10-09T23:58:06Z

src/modm/driver/display/ssd1306_i2c.lb

 def init(module):
-    module.name = ":driver:ssd1306"
-    module.description = "SSD1306 Display"
+    module.name = ":driver:ssd1306.i2c"


Should we add an alias for the old module name?
If so, how does it work?

yes, with module.add_alias in the :driver module. See example here. Also add a DEPRECATED: 2024q4 so we can remove it and not forget it like in my own example *cough*😇.

I added the following code to src/modm/driver/module.lb:

# DEPRECATED: 2024q4 module.add_alias( Alias(name="ssd1306", destination=":ssd1306.i2c", description="DEPRECATED: Please use :driver:ssd1306.i2c instead."))

lbuild recognizes the alias and does not complain if I use it in project.xml, but does not generate any files...

needs to be destination=":driver:ssd1306.i2c", I'll check why it doesn't complain.

Nope, still does not work 😞

Oh ffs, I'll check it over the weekend. I need to rewrite lbuild, it's so unpythonic…

It does build the alias destination for me though.

The reason it doesn't give a warning is that the :driver:ssd1306.i2c module is a dependency of the :driver:sh1106.i2c module, and is thus already included by the time the alias is resolved. If you change the dependency back to the alias:

$ lbuild build [WARNING] lbuild.node: Node 'modm:driver:ssd1306' has been moved to ':driver:ssd1306.i2c'! >> modm:driver:ssd1306 [Alias] DEPRECATED: Please use `:driver:ssd1306.i2c` instead. Destination: :driver:ssd1306.i2c >> modm:driver:ssd1306.i2c [Module] SSD1306 Display in I2C mode

rleh · 2023-10-10T17:37:09Z

All drivers (ssd1306.i2c, ssd1306.spi and sh1106.i2c) are now tested successfully on Hardware with a HP12832-02 module for SPI and respectively a GME12864-41 module for I²C.

rleh · 2023-10-10T17:55:30Z

src/modm/driver/display/sh1106_i2c.hpp

-		this->commandBuffer[0] = ssd1306::AdressingCommands::HigherColumnStartAddress;
-		this->commandBuffer[1] = 0x02;
-
 		for (page = 0; page < Height / 8; page++)
 		{
-			this->commandBuffer[2] = 0xB0 | page;
-			this->transaction_success &= RF_CALL(this->writeCommands(3));


The command sequence {0x10, 0x02, 0xB0 | page} gets interpreted (at least on my SSD1306 GME12864 module) as three command:
1.0x10: Set Higher Column Start Address for Page Addressing Mode (10h~1Fh) to value 0
2.0x02 Set Lower Column Start Address for Page Addressing Mode (00h~0Fh) to value 2
3. 0xB0 Set Page Start Address for Page Addressing Mode (B0h~B7h) to value page

The first two commands result in the first two columns of display pixels displaying garbage and the last two columns of the frame not getting displayed, so I removed them.
SSD1106 should behave the same way like SH1106 in Page Addressing Mode, but I don't have SH1106 hardware laying arround, so I can't test it. Maybe @TomSaw could check?

And the hardware test shows:
These lines have a purpose. Whitout, the displays pages (columns of pixels) get ugly shifted.
I remember having read about this necessary micro-management in an adafruit or arduino library comment, not in the datasheet or elsewhere.

chris-durand

Nice!

examples/nucleo_g474re/sh1106_i2c/main.cpp

src/modm/driver/display/sh1106_i2c.hpp

src/modm/driver/display/ssd1306_i2c.hpp

src/modm/driver/display/ssd1306_i2c_impl.hpp

README.md

src/modm/driver/display/ssd1306_i2c.lb

src/modm/driver/display/ssd1306_i2c.hpp

src/modm/driver/display/ssd1306.hpp

rleh · 2023-10-11T12:55:58Z

As I understood, you could test with sh1106 @rleh ? I've got these around. Let me know if I can help with hardware tests.

@TomSaw I tested the examples/nucleo_g474re/sh1106_i2c/ example only with an (genuine) SSD1306 display module, because I don't have any SH1106 modules.
It would be very cool if you could test the example with your SH1106 display.
I assume you know how to get the example running on a dev board other than the Nucleo-G474RE, otherwise let me know if you need help.

TomSaw · 2023-10-11T13:57:52Z

As I understood, you could test with sh1106 @rleh ? I've got these around. Let me know if I can help with hardware tests.

@TomSaw I tested the examples/nucleo_g474re/sh1106_i2c/ example only with an (genuine) SSD1306 display module, because I don't have any SH1106 modules.
It would be very cool if you could test the example with your SH1106 display.
I assume you know how to get the example running on a dev board other than the Nucleo-G474RE, otherwise let me know if you need help.

ok, but gimme 1,2 days pls.

salkinium · 2023-12-12T12:23:10Z

Is there an update for this?

TomSaw · 2024-03-05T21:44:22Z

Tested SH1106 and you actually have to keep the ssd1306::AdressingCommands::HigherColumnStartAddress` assignments in the SH1106 driver if you don't have a preference for fuzzy diagonally shifted pages of pixels.

The memory mapping of sh1106 is different (and worse) than SSD1306

salkinium · 2024-09-29T13:37:07Z

Can I merge this? What's the status of this?

rleh · 2024-09-29T15:29:47Z

I have to test/debug and maybe fix the problem with the SH1106.

rleh added feature 🚧 example 🔑 labels Oct 9, 2023

rleh commented Oct 9, 2023

View reviewed changes

rleh force-pushed the ssd1306_spi branch 3 times, most recently from efc4ce5 to b9dd0fb Compare October 10, 2023 17:29

rleh requested review from chris-durand and salkinium October 10, 2023 17:30

rleh commented Oct 10, 2023

View reviewed changes

chris-durand reviewed Oct 10, 2023

View reviewed changes

salkinium reviewed Oct 10, 2023

View reviewed changes

README.md Outdated Show resolved Hide resolved

src/modm/driver/display/ssd1306_i2c.lb Outdated Show resolved Hide resolved

src/modm/driver/display/ssd1306_i2c.hpp Show resolved Hide resolved

src/modm/driver/display/ssd1306.hpp Outdated Show resolved Hide resolved

rleh force-pushed the ssd1306_spi branch from b9dd0fb to bc90647 Compare October 11, 2023 08:02

rleh added 5 commits October 11, 2023 10:11

[driver] Rename SSD1306 driver to ssd1306.i2c

def628e

[examples] Update SSD1306 examples

a06da05

[examples] Add SH1106/SSD1306 I2C display example for Nucleo-G474RE

77ba35a

[driver] Add SSD1306 SPI driver

275c635

[examples] Add SSD1306 SPI display example for Nucleo-G474RE

4c0e511

rleh force-pushed the ssd1306_spi branch from bc90647 to 4c0e511 Compare October 11, 2023 08:11

Conversation

rleh commented Oct 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rleh Oct 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rleh commented Oct 10, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chris-durand left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rleh commented Oct 11, 2023

Uh oh!

TomSaw commented Oct 11, 2023

Uh oh!

salkinium commented Dec 12, 2023

Uh oh!

TomSaw commented Mar 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

salkinium commented Sep 29, 2024

Uh oh!

rleh commented Sep 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

rleh commented Oct 9, 2023 •

edited

Loading

rleh Oct 9, 2023 •

edited

Loading

TomSaw commented Mar 5, 2024 •

edited

Loading

rleh commented Sep 29, 2024 •

edited

Loading