Skip to content

assign3: adding assignment 3 solution#46

Open
mdawar-cs wants to merge 2 commits intomohammadrajabraza:mainfrom
mdawar-cs:assign3/mdawar-piaic-125642
Open

assign3: adding assignment 3 solution#46
mdawar-cs wants to merge 2 commits intomohammadrajabraza:mainfrom
mdawar-cs:assign3/mdawar-piaic-125642

Conversation

@mdawar-cs
Copy link

No description provided.

Copy link
Owner

@mohammadrajabraza mohammadrajabraza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's best practice to exclude environment (i.e. .env) files from source code. Please exclude this and resubmit. Also, I would recommend you to participate in the Hacktoberfest 2021 and follow the contribution instructions from there for this PR.

Copy link
Owner

@mohammadrajabraza mohammadrajabraza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. But you could merge your new changes into a single commit. You try to reset 1st commit and remove .env file then it wouldn't even appear in the git history.

@mohammadrajabraza mohammadrajabraza added the hacktoberfest-accepted Fulfill the acceptance criteria label Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hacktoberfest-accepted Fulfill the acceptance criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants