docs: linked the wiki page explaining FLINT modules#173
docs: linked the wiki page explaining FLINT modules#173Namyalg wants to merge 3 commits intomoja-global:masterfrom
Conversation
| - Decomposition module | ||
| - RothC soil carbon module | ||
|
|
||
| More information about these modules can be found `here`_ |
There was a problem hiding this comment.
Please avoid using here. Refer on our modules documentation.
shloka-gupta
left a comment
shloka-gupta
left a comment
There was a problem hiding this comment.
Hi, @Namyalg I have just put up a few thoughts. Do let me know what do you think?
| What is a module? | ||
| ----------------- | ||
|
|
||
| A module is a self-contained set of operations that determine the state |
There was a problem hiding this comment.
A question that may arise in a reader's mind is-- "What kind of operations?"
There was a problem hiding this comment.
IMO linking the operations.rst here should serve the purpose
| How do modules operate? | ||
| ----------------------- | ||
|
|
||
| Each module reads (or is provided with – see Unit Controller) |
There was a problem hiding this comment.
From a new reader's prespective-
'see Unit Controller' for what?
There was a problem hiding this comment.
The concept of a unit controller is not very clear, can we have a page/section for this and link it everywhere it is mentioned?
There was a problem hiding this comment.
Suggest removing unit controllers for now.
| Modules for disturbance events | ||
| ------------------------------ | ||
|
|
||
| Disturbance events occur intermittently (rather than for every step in a |
There was a problem hiding this comment.
I think it would be a good idea to add a line at the beginning about what are Disturbance events are before jumping it?
There was a problem hiding this comment.
Yes, the interpretation of a disturbance can be added first, then about the modules
4 participants
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Thanks for opening the Pull Request for moja global. Happy contributing ✨