Suggestion about Field.get Method#45
Open
brasiqui wants to merge 4 commits intomoleculerjs:masterfrom
Open
Conversation
icebob
requested changes
May 21, 2023
Member
icebob
left a comment
icebob
left a comment
There was a problem hiding this comment.
Good idea, could you plz add a test to it?
Author
|
Now, I wrote a test. But I couldn't run it locally. |
Member
|
Could you show the error message? |
Author
|
|
Author
|
Tests updated. |
icebob
reviewed
May 24, 2023
| name: "John Doe", | ||
| upperName: "Nothing", | ||
| lowerName: "Nothing", | ||
| lengthName: 0, |
Member
There was a problem hiding this comment.
They are readonly fields, why do you send them in create?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Another suggestion.
Would it be possible to enable insertion of a string pointing to a method for field.get as it exists in field.set?
Sometimes the logic for transforming the value can be extensive and using a method would be more organized.
Thanks,
Roni Cruz