feat(types): add middlewares types#1161
Open
thib3113 wants to merge 9 commits intomoleculerjs:masterfrom
Open
Conversation
Member
shawnmcknight
left a comment
There was a problem hiding this comment.
A couple things here:
- What's the use case for making this change?
- Although there are many places in the existing types where
namespaceis used, its a pattern I'd prefer to avoid in the future. Can the changes you're making be accomplished without using them? - Types should always be PascalCase and not camelCase. There are several changes here using camelCase.
Contributor
Author
- remove namespaces - rename types as PascalCase
Contributor
Author
- fix TU
Contributor
Author
|
@shawnmcknight any news on this ? |
shawnmcknight
requested changes
Mar 19, 2023
Member
shawnmcknight
left a comment
There was a problem hiding this comment.
Overall this looks good. I had a few requests for adjustment.
- back to namespaces - correct PascalCase
Contributor
Author
|
Please @shawnmcknight / @icebob can you review this PR ? it is waiting for nearly a year, where PR #1246 with same changes was validated in 2 days (litterally the PR just re-do a part of this one) ... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Add typing for the optionals middlewares
PS : I typed the encryption middleware too, but I think it's not a good middleware, not secure (IV not changing), and hard to use (password length need to be a strict length)
💎 Type of change
🏁 Checklist: