feat(radio-simple and group): make aria-label(ledby) required#747
Merged
nataliadelmar merged 4 commits intomomentum-design:masterfrom Jan 7, 2025
Merged
Conversation
| ariaLabelledBy?: string; | ||
| import { AriaLabelRequired } from '../../utils/a11y'; | ||
|
|
||
| export type RadioSimpleProps = AriaLabelRequired & { |
Collaborator
There was a problem hiding this comment.
suggestion: can we add back AriaRadioProps. It adds a few aria props that we are losing by removing it.
| className?: string; | ||
| export type RadioSimpleGroupProps = AriaRadioGroupProps & | ||
| AriaLabelingProps & | ||
| ( |
Collaborator
There was a problem hiding this comment.
suggestion: use RequireOneOf. See Checkbox.types.tsx
dominiccarrington
approved these changes
Jan 7, 2025
Collaborator
dominiccarrington
left a comment
dominiccarrington
left a comment
There was a problem hiding this comment.
LGTM! Thanks for addressing comments!
|
🎉 This PR is included in version 26.193.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make aria-label(ledby) required on RadioSimple and RadioSimpleGroup.
On RadioSimpleGroup, if a label prop is passed, useRadioGroup automatically links it to the group with aria-labelledby. No need to link them manually.
RadioSimpleGroup: https://jira-eng-gpk2.cisco.com/jira/browse/SPARK-598563
RadioSimple: https://jira-eng-gpk2.cisco.com/jira/browse/SPARK-598565