feat(alert-banner): do not render button section if no buttons passes#757
Closed
nataliadelmar wants to merge 1 commit intomomentum-design:masterfrom
Closed
feat(alert-banner): do not render button section if no buttons passes#757nataliadelmar wants to merge 1 commit intomomentum-design:masterfrom
nataliadelmar wants to merge 1 commit intomomentum-design:masterfrom
Conversation
Collaborator
Author
|
we don't need this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the moment, AlertBannerNext has an optional property buttons that accepts a ReactElement[]. If not defined, AlertBanner still draws its container, leaving a weird blank space at the end of the banner.
If we have no buttons, we want the space not to be there