Skip to content

Comments

feat(coachmark): create coachmark web component wrapper#767

Merged
gabrielchl merged 10 commits intomasterfrom
feat/SPARK-629057-create-coachmark-component
Mar 18, 2025
Merged

feat(coachmark): create coachmark web component wrapper#767
gabrielchl merged 10 commits intomasterfrom
feat/SPARK-629057-create-coachmark-component

Conversation

@gabrielchl
Copy link
Collaborator

@gabrielchl gabrielchl commented Mar 15, 2025

IMPORTANT

Currently, this project is closed to any external contributions. Any pull request made against this project from external sources will likely be closed. If you would like to make changes to this project, please fork this project.

Guide

This "Help" section can be deleted before submitting this pull request.

Update the name of this pull request to reflect the following shape:

{type}/{scope?}/{message}
  • type - A conventional commit type REQUIRED
  • scope - The kabab-case scope of the changes in this request
  • message - A short, kebab-case statement describing the changes REQUIRED

Provide a general summary of the scope of the changes in this pull request.

Description

  • creating the coachmark web component wrapper, keeping this one simple as it's purely a wrapper, passing through some props
  • the old coachmark component is removed as part of this, as it's unused

Links

https://jira-eng-gpk2.cisco.com/jira/browse/SPARK-629057
https://jira-eng-gpk2.cisco.com/jira/browse/SPARK-636867

@gabrielchl gabrielchl marked this pull request as ready for review March 17, 2025 10:48
@gabrielchl gabrielchl force-pushed the feat/SPARK-629057-create-coachmark-component branch from 823e7c2 to fd88d4f Compare March 18, 2025 16:54
@gabrielchl gabrielchl merged commit 21593f0 into master Mar 18, 2025
5 checks passed
@github-actions
Copy link

🎉 This PR is included in version 26.199.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants