fix: migrate buttondialpad#786
Merged
cscheffauer merged 3 commits intomomentum-design:masterfrom Apr 11, 2025
Merged
Conversation
jor-row
requested changes
Apr 10, 2025
Collaborator
jor-row
left a comment
jor-row
left a comment
There was a problem hiding this comment.
some very small comments like unused constants that can be removed and a type issue
| primaryText: `${CLASS_PREFIX}-primary-text`, | ||
| secondaryText: `${CLASS_PREFIX}-secondary-text`, | ||
| wrapper: `${CLASS_PREFIX}-wrapper`, | ||
| innerWrapper: `${CLASS_PREFIX}-inner-wrapper`, |
Collaborator
There was a problem hiding this comment.
The default SIZE and SIZE constants can also be removed as they are no longer needed
Collaborator
There was a problem hiding this comment.
the default for DISABLED is only used in a test so can be removed as well
| // size in scss file to 64px | ||
| size={40} | ||
| variant="tertiary" | ||
| {...(otherProps as any)} |
Collaborator
There was a problem hiding this comment.
can we type this otherProps? as Omit<Props, 'className'>
|
|
||
| return ( | ||
| <ButtonSimple | ||
| <MdcButton |
Collaborator
There was a problem hiding this comment.
the disabled button doesn't really look disabled but i guess it was that way before so its fine as is
chrisadubois
approved these changes
Apr 10, 2025
jor-row
approved these changes
Apr 11, 2025
|
🎉 This PR is included in version 26.201.10 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description