fix(sass): changed slashes to math.div#1177
Closed
peter7cole wants to merge 5 commits intomomentum-design:masterfrom
Closed
fix(sass): changed slashes to math.div#1177peter7cole wants to merge 5 commits intomomentum-design:masterfrom
peter7cole wants to merge 5 commits intomomentum-design:masterfrom
Conversation
peter7cole
commented
Mar 11, 2022
| #{$circle-size}, | ||
| calc(#{$circle-size} / 2) | ||
| ); | ||
| clip: rect(0px, #{$circle-size}, #{$circle-size}, calc(#{$circle-size} / 2)); |
Contributor
Author
There was a problem hiding this comment.
having some issues with the formatting, but this matches the printWidth: 100 in the .prettierrc.json file
eazy-g
reviewed
Mar 11, 2022
Collaborator
eazy-g
left a comment
eazy-g
left a comment
There was a problem hiding this comment.
Thanks for taking this on @peter7cole ! I was just running into same headache
| @@ -4244,10 +4241,10 @@ $definition-list-margin-bottom: 0.5rem; | |||
|
|
|||
| // ex.: golden ratio | |||
| // current: 16 * 1.71429 / 4 = 6.85716 | |||
| $base-scale: $base-unit-rem * $base-line-height-ratio / $base-unit-px; | |||
| $base-scale: $base-unit-rem * calc($base-line-height-ratio / $base-unit-px); | |||
Collaborator
There was a problem hiding this comment.
Tests are failing on these...I think you have to use #{$base-line-height-ratio} format when referencing variables in calc()
Contributor
Author
There was a problem hiding this comment.
got it, thank you for the catch
Contributor
Author
@eazy-g thank you, I'm going to link a new PR and close this one as I'm running into a bit of a headache geting github to sync formatting UPDATE: #1179 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses a Deprecation Warning that we've noticed in our builds for the Webex admin portal.
Linked announcement here: https://sass-lang.com/documentation/breaking-changes/slash-div
Related Issue
Deprecation Warning: Sass Slashes #1176
Motivation and Context
We would like to clear our warnings
Screenshots:
Types of changes
Checklist: