Skip to content

Comments

Phenotype Node Page Redesign#1200

Open
varun-divya wants to merge 19 commits intomainfrom
issue-1198-phenotype-node-page
Open

Phenotype Node Page Redesign#1200
varun-divya wants to merge 19 commits intomainfrom
issue-1198-phenotype-node-page

Conversation

@varun-divya
Copy link
Contributor

@varun-divya varun-divya commented Sep 5, 2025

Related issues

Please make sure to test the edge-case phenotypes as well . 🙂

@varun-divya varun-divya self-assigned this Sep 5, 2025
@varun-divya varun-divya marked this pull request as draft September 5, 2025 15:54
@netlify
Copy link

netlify bot commented Sep 5, 2025

Deploy Preview for monarch-app ready!

Name Link
🔨 Latest commit b8f70dd
🔍 Latest deploy log https://app.netlify.com/projects/monarch-app/deploys/68f12e9b6ed5f400087780a5
😎 Deploy Preview https://deploy-preview-1200--monarch-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link

codecov bot commented Sep 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.84%. Comparing base (1f2828a) to head (b8f70dd).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1200   +/-   ##
=======================================
  Coverage   71.84%   71.84%           
=======================================
  Files          92       92           
  Lines        3232     3232           
=======================================
  Hits         2322     2322           
  Misses        910      910           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@varun-divya varun-divya marked this pull request as ready for review October 16, 2025 15:16
Copy link
Member

@sagehrke sagehrke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The "Disease Phenotype" section should be called "Diseases with this Phenotype" and the tab should be "Directly associated diseases" and "Inferred associated diseases"
  • The "Causal Gene Phenotypes" section should be called "Causal Genes" and the tab should be "Directly associated causal genes" and "Inferred associated causal genes"

I think the rest is ok! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Redesign phenotype node pages on mi.org

2 participants