Use curies implementation for extracting prefixes#9539
Open
cthoyt wants to merge 2 commits intomonarch-initiative:masterfrom
Open
Use curies implementation for extracting prefixes#9539cthoyt wants to merge 2 commits intomonarch-initiative:masterfrom
cthoyt wants to merge 2 commits intomonarch-initiative:masterfrom
Conversation
I'm doing a GitHub-wide cleanup of operations on dataframes with CURIEs in them, replacing with functionality that's tested and hardened in the upstream `curies` package cc @matentzn
Member
|
Nice, is this available in which is what we depend on? |
Contributor
Author
|
nope, i just added it today, so we need curies 0.10.21 (https://github.com/biopragmatics/curies/releases/tag/v0.10.21) |
matentzn
requested changes
Sep 5, 2025
Member
There was a problem hiding this comment.
Blocked by 0.10.21 requirement, which requires
- an ODK minor release
- migration of Mondo to ODK minor release
Contributor
Author
There was a problem hiding this comment.
es lohnt sich!
actually i realize there was a tiny backwards compatible import change so we need 0.10.21, which I just released
Contributor
|
@matentzn are you managing this PR? |
Member
|
Yes. Assigned to myself now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm doing a GitHub-wide cleanup of operations on dataframes with CURIEs in them, replacing with functionality that's tested and hardened in the upstream
curiespackagecc @matentzn