Skip to content

Comments

Bug fix: title symbol splitting#193

Open
joeflack4 wants to merge 1 commit intomainfrom
bugfix-title-symbol-splitting
Open

Bug fix: title symbol splitting#193
joeflack4 wants to merge 1 commit intomainfrom
bugfix-title-symbol-splitting

Conversation

@joeflack4
Copy link
Contributor

Partially addresses:

Summary of fix

Addressing issue where should have been including a space when splitting, e.g. '; ' and ';; '.

Context

Basically, OMIM has title/symbol pairs in mimTitles.txt. The pairs are delimited by ;; . And in each pair, the first entry is a title, with a ; after it if there are any associated symbols, with further ; delimiting each of those symbols.

- Addressing issue where should have been including a space when splitting, e.g. '; ' and ';; '.
@joeflack4 joeflack4 marked this pull request as draft February 5, 2025 02:51
@joeflack4 joeflack4 self-assigned this Feb 5, 2025
@joeflack4 joeflack4 added the bug Something isn't working label Feb 5, 2025
@joeflack4 joeflack4 changed the base branch from main to develop February 5, 2025 02:52
@joeflack4
Copy link
Contributor Author

joeflack4 commented Feb 5, 2025

@twhetzel Here's the diff after running this:

94116d94115
< AnnotationAssertion(Annotation(<http://www.geneontology.org/formats/oboInOwl#hasSynonymType> <http://purl.obolibrary.org/obo/OMO_0003000>) <http://www.geneontology.org/formats/oboInOwl#hasExactSynonym> <https://omim.org/entry/172200> ". PGD, ERYTHROCYTE")
94118c94117
< AnnotationAssertion(<http://www.geneontology.org/formats/oboInOwl#hasExactSynonym> <https://omim.org/entry/172200> "6-phosphogluconate dehydrogenase, erythrocyte")
---
> AnnotationAssertion(<http://www.geneontology.org/formats/oboInOwl#hasExactSynonym> <https://omim.org/entry/172200> "6-phosphogluconate dehydrogenase, erythrocyte;. pgd, erythrocyte")
311200,311202c311199,311200
< AnnotationAssertion(Annotation(<http://www.geneontology.org/formats/oboInOwl#hasSynonymType> <http://purl.obolibrary.org/obo/OMO_0003000>) <http://www.geneontology.org/formats/oboInOwl#hasExactSynonym> <https://omim.org/entry/609029> "22) SYNDROME")
< AnnotationAssertion(<http://www.geneontology.org/formats/oboInOwl#hasExactSynonym> <https://omim.org/entry/609029> "emanuel syndrome")
< AnnotationAssertion(<http://www.geneontology.org/formats/oboInOwl#hasExactSynonym> <https://omim.org/entry/609029> "supernumerary der(22)t(11")
---
> AnnotationAssertion(<http://www.geneontology.org/formats/oboInOwl#hasExactSynonym> <https://omim.org/entry/609029> "emanuel syndrome")
> AnnotationAssertion(<http://www.geneontology.org/formats/oboInOwl#hasExactSynonym> <https://omim.org/entry/609029> "supernumerary der(22)t(11;22) syndrome")
379173c379171
< # Class: <https://omim.org/entry/613700> (supernumerary der(22)t(8)
---
> # Class: <https://omim.org/entry/613700> (supernumerary der(22)t(8;22) syndrome)
379175,379177c379173,379174
< AnnotationAssertion(Annotation(<http://www.geneontology.org/formats/oboInOwl#hasSynonymType> <http://purl.obolibrary.org/obo/OMO_0003000>) <http://www.geneontology.org/formats/oboInOwl#hasExactSynonym> <https://omim.org/entry/613700> "22) SYNDROME")
< AnnotationAssertion(<http://www.geneontology.org/formats/oboInOwl#hasExactSynonym> <https://omim.org/entry/613700> "supernumerary der(22)t(8")
< AnnotationAssertion(rdfs:label <https://omim.org/entry/613700> "supernumerary der(22)t(8")
---
> AnnotationAssertion(<http://www.geneontology.org/formats/oboInOwl#hasExactSynonym> <https://omim.org/entry/613700> "supernumerary der(22)t(8;22) syndrome")
> AnnotationAssertion(rdfs:label <https://omim.org/entry/613700> "supernumerary der(22)t(8;22) syndrome")

Looks good, except I think this new one is might be mistake: AnnotationAssertion(<http://www.geneontology.org/formats/oboInOwl#hasExactSynonym> <https://omim.org/entry/172200> "6-phosphogluconate dehydrogenase, erythrocyte;. pgd, erythrocyte")

I think maybe that ;. is supposed to be ;;, and that this should be 2 different titles.

I emailed OMIM about this, replying to an existing email chain that had a similar issue. Email subject: 301083 alt title;symbol syntax mistake

@joeflack4 joeflack4 marked this pull request as ready for review February 5, 2025 03:58
@joeflack4 joeflack4 requested a review from twhetzel February 5, 2025 03:58
Base automatically changed from develop to main February 21, 2025 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant