Open
Conversation
lerouxb
added
the
no-title-validation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds TypeScript type definitions for the mkdirp package to resolve import errors in scripts/update-grammer.ts that were preventing VSCode and the watch command from running properly.
Changes:
- Added
@types/mkdirpversion 1.0.1 to devDependencies
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Anemy
approved these changes
Jan 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vscode and pnpm run watch (one of the commands it ultimately executes) wasn't happy about a line in scripts/update-grammer.ts where we import mkdirp.
Coincidentally this is now the latest version of @types/mkdirp because the latest one causes ELSPROBLEMS.
I have no idea why this only affects me and only starting today.